Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update restyled-machines template #21

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

pbrisbin
Copy link
Member

  • Use object syntax
  • Remove unnecessary increment comment

This will rotate the ASG due to an AMI update, which is also good. The
currently-deployed AMI (in case we need to roll back) is
ami-0dc67873410203528

- Use object syntax
- Remove unnecessary increment comment

This will rotate the ASG due to an AMI update, which is also good. The
currently-deployed AMI (in case we need to roll back) is
`ami-0dc67873410203528`
@pbrisbin pbrisbin force-pushed the pb/update-restyled-machines branch from b4c50e1 to 0500103 Compare May 23, 2024 16:54
Copy link

⚠️ This PR generates 7 changes for stacks/restyled.760048635536/us-east-1/prod/services/restyle-machines.yaml.

Action Logical Id Physical Id Type Replacement Scope Details
Modify LaunchConfiguration prod-services-restyle-machines-LaunchConfiguration-d3ICtRl7ZkE5 AWS::AutoScaling::LaunchConfiguration True Properties
  • DirectModification in Properties (ImageId), recreation Always
  • DirectModification in Properties (UserData), recreation Always
Modify AutoScalingGroup prod-services-restyle-machines-AutoScalingGroup-13H9RGYYO7D7X AWS::AutoScaling::AutoScalingGroup Conditional Properties
  • ResourceReference in Properties (LaunchConfigurationName), recreation Conditionally, caused by LaunchConfiguration
Modify Dashboard restyled-prod-restyle-machines AWS::CloudWatch::Dashboard Conditional Properties
  • ResourceReference in Properties (DashboardBody), recreation Conditionally, caused by AutoScalingGroup
Modify ScaleDownPolicy arn:aws:autoscaling:us-east-1:760048635536:scalingPolicy:251e61b7-3028-4b23-bdd0-4ca6ea2a0413:autoScalingGroupName/prod-services-restyle-machines-AutoScalingGroup-13H9RGYYO7D7X:policyName/prod-services-restyle-machines-ScaleDownPolicy-1RT24AQADE52D AWS::AutoScaling::ScalingPolicy Conditional Properties
  • ResourceReference in Properties (AutoScalingGroupName), recreation Always, caused by AutoScalingGroup
Modify ScaleDownAlarm prod-services-restyle-machines-ScaleDownAlarm-NR2SHALQFKSG AWS::CloudWatch::Alarm False Properties
  • ResourceReference in Properties (AlarmActions), recreation Never, caused by ScaleDownPolicy
Modify ScaleUpPolicy arn:aws:autoscaling:us-east-1:760048635536:scalingPolicy:d1bcfbba-c034-4e7c-b283-c5aca6cf386d:autoScalingGroupName/prod-services-restyle-machines-AutoScalingGroup-13H9RGYYO7D7X:policyName/prod-services-restyle-machines-ScaleUpPolicy-OVTYYV7ZLU4R AWS::AutoScaling::ScalingPolicy Conditional Properties
  • ResourceReference in Properties (AutoScalingGroupName), recreation Always, caused by AutoScalingGroup
Modify ScaleUpAlarm prod-services-restyle-machines-ScaleUpAlarm-1O045SES86U5N AWS::CloudWatch::Alarm False Properties
  • ResourceReference in Properties (AlarmActions), recreation Never, caused by ScaleUpPolicy
Full changes
{
    "capabilities": null,
    "changeSetId": "arn:aws:cloudformation:us-east-1:760048635536:changeSet/stackctl-202405231655-32ae4e6b-1b06-4a3d-8c4e-571161308a82/86a076de-4806-4251-ab90-ca61100f25da",
    "changeSetName": "stackctl-202405231655-32ae4e6b-1b06-4a3d-8c4e-571161308a82",
    "changes": [
        {
            "hookInvocationCount": null,
            "resourceChange": {
                "action": "Modify",
                "changeSetId": null,
                "details": [
                    {
                        "causingEntity": "LaunchConfiguration",
                        "changeSource": "ResourceReference",
                        "evaluation": "Static",
                        "target": {
                            "attribute": "Properties",
                            "name": "LaunchConfigurationName",
                            "requiresRecreation": "Conditionally"
                        }
                    }
                ],
                "logicalResourceId": "AutoScalingGroup",
                "moduleInfo": null,
                "physicalResourceId": "prod-services-restyle-machines-AutoScalingGroup-13H9RGYYO7D7X",
                "replacement": "Conditional",
                "resourceType": "AWS::AutoScaling::AutoScalingGroup",
                "scope": [
                    "Properties"
                ]
            },
            "type'": "Resource"
        },
        {
            "hookInvocationCount": null,
            "resourceChange": {
                "action": "Modify",
                "changeSetId": null,
                "details": [
                    {
                        "causingEntity": "AutoScalingGroup",
                        "changeSource": "ResourceReference",
                        "evaluation": "Dynamic",
                        "target": {
                            "attribute": "Properties",
                            "name": "DashboardBody",
                            "requiresRecreation": "Conditionally"
                        }
                    }
                ],
                "logicalResourceId": "Dashboard",
                "moduleInfo": null,
                "physicalResourceId": "restyled-prod-restyle-machines",
                "replacement": "Conditional",
                "resourceType": "AWS::CloudWatch::Dashboard",
                "scope": [
                    "Properties"
                ]
            },
            "type'": "Resource"
        },
        {
            "hookInvocationCount": null,
            "resourceChange": {
                "action": "Modify",
                "changeSetId": null,
                "details": [
                    {
                        "causingEntity": null,
                        "changeSource": "DirectModification",
                        "evaluation": "Static",
                        "target": {
                            "attribute": "Properties",
                            "name": "ImageId",
                            "requiresRecreation": "Always"
                        }
                    },
                    {
                        "causingEntity": null,
                        "changeSource": "DirectModification",
                        "evaluation": "Static",
                        "target": {
                            "attribute": "Properties",
                            "name": "UserData",
                            "requiresRecreation": "Always"
                        }
                    }
                ],
                "logicalResourceId": "LaunchConfiguration",
                "moduleInfo": null,
                "physicalResourceId": "prod-services-restyle-machines-LaunchConfiguration-d3ICtRl7ZkE5",
                "replacement": "True",
                "resourceType": "AWS::AutoScaling::LaunchConfiguration",
                "scope": [
                    "Properties"
                ]
            },
            "type'": "Resource"
        },
        {
            "hookInvocationCount": null,
            "resourceChange": {
                "action": "Modify",
                "changeSetId": null,
                "details": [
                    {
                        "causingEntity": "ScaleDownPolicy",
                        "changeSource": "ResourceReference",
                        "evaluation": "Dynamic",
                        "target": {
                            "attribute": "Properties",
                            "name": "AlarmActions",
                            "requiresRecreation": "Never"
                        }
                    }
                ],
                "logicalResourceId": "ScaleDownAlarm",
                "moduleInfo": null,
                "physicalResourceId": "prod-services-restyle-machines-ScaleDownAlarm-NR2SHALQFKSG",
                "replacement": "False",
                "resourceType": "AWS::CloudWatch::Alarm",
                "scope": [
                    "Properties"
                ]
            },
            "type'": "Resource"
        },
        {
            "hookInvocationCount": null,
            "resourceChange": {
                "action": "Modify",
                "changeSetId": null,
                "details": [
                    {
                        "causingEntity": "AutoScalingGroup",
                        "changeSource": "ResourceReference",
                        "evaluation": "Dynamic",
                        "target": {
                            "attribute": "Properties",
                            "name": "AutoScalingGroupName",
                            "requiresRecreation": "Always"
                        }
                    }
                ],
                "logicalResourceId": "ScaleDownPolicy",
                "moduleInfo": null,
                "physicalResourceId": "arn:aws:autoscaling:us-east-1:760048635536:scalingPolicy:251e61b7-3028-4b23-bdd0-4ca6ea2a0413:autoScalingGroupName/prod-services-restyle-machines-AutoScalingGroup-13H9RGYYO7D7X:policyName/prod-services-restyle-machines-ScaleDownPolicy-1RT24AQADE52D",
                "replacement": "Conditional",
                "resourceType": "AWS::AutoScaling::ScalingPolicy",
                "scope": [
                    "Properties"
                ]
            },
            "type'": "Resource"
        },
        {
            "hookInvocationCount": null,
            "resourceChange": {
                "action": "Modify",
                "changeSetId": null,
                "details": [
                    {
                        "causingEntity": "ScaleUpPolicy",
                        "changeSource": "ResourceReference",
                        "evaluation": "Dynamic",
                        "target": {
                            "attribute": "Properties",
                            "name": "AlarmActions",
                            "requiresRecreation": "Never"
                        }
                    }
                ],
                "logicalResourceId": "ScaleUpAlarm",
                "moduleInfo": null,
                "physicalResourceId": "prod-services-restyle-machines-ScaleUpAlarm-1O045SES86U5N",
                "replacement": "False",
                "resourceType": "AWS::CloudWatch::Alarm",
                "scope": [
                    "Properties"
                ]
            },
            "type'": "Resource"
        },
        {
            "hookInvocationCount": null,
            "resourceChange": {
                "action": "Modify",
                "changeSetId": null,
                "details": [
                    {
                        "causingEntity": "AutoScalingGroup",
                        "changeSource": "ResourceReference",
                        "evaluation": "Dynamic",
                        "target": {
                            "attribute": "Properties",
                            "name": "AutoScalingGroupName",
                            "requiresRecreation": "Always"
                        }
                    }
                ],
                "logicalResourceId": "ScaleUpPolicy",
                "moduleInfo": null,
                "physicalResourceId": "arn:aws:autoscaling:us-east-1:760048635536:scalingPolicy:d1bcfbba-c034-4e7c-b283-c5aca6cf386d:autoScalingGroupName/prod-services-restyle-machines-AutoScalingGroup-13H9RGYYO7D7X:policyName/prod-services-restyle-machines-ScaleUpPolicy-OVTYYV7ZLU4R",
                "replacement": "Conditional",
                "resourceType": "AWS::AutoScaling::ScalingPolicy",
                "scope": [
                    "Properties"
                ]
            },
            "type'": "Resource"
        }
    ],
    "creationTime": "2024-05-23T16:55:06Z",
    "description": null,
    "executionStatus": "AVAILABLE",
    "httpStatus": 200,
    "includeNestedStacks": false,
    "nextToken": null,
    "notificationARNs": null,
    "parameters": [
        {
            "parameterKey": "ScaleUpCapacity",
            "parameterValue": "3",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "RedisUrl",
            "parameterValue": "****",
            "resolvedValue": "****",
            "usePreviousValue": null
        },
        {
            "parameterKey": "RestyledToken",
            "parameterValue": "****",
            "resolvedValue": "****",
            "usePreviousValue": null
        },
        {
            "parameterKey": "UserDataSourceKey",
            "parameterValue": "src/restyle-machines/user-data/737b4ec724e2710acb34956a960d31fb0edbfe1f",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "DesiredCapacity",
            "parameterValue": "1",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "DatadogSite",
            "parameterValue": "datadoghq.com",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "DatadogAgentMajorVersion",
            "parameterValue": "7",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "Name",
            "parameterValue": "restyle-machines",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "GitHubAppKey",
            "parameterValue": "****",
            "resolvedValue": "****",
            "usePreviousValue": null
        },
        {
            "parameterKey": "DatadogApiKey",
            "parameterValue": "****",
            "resolvedValue": "****",
            "usePreviousValue": null
        },
        {
            "parameterKey": "RestylerPoolSize",
            "parameterValue": "3",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "ScaleUpThreshold",
            "parameterValue": "30",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "InstanceAmi",
            "parameterValue": "/aws/service/ecs/optimized-ami/amazon-linux-2/recommended/image_id",
            "resolvedValue": "ami-0cf60a53ad9cf9e40",
            "usePreviousValue": null
        },
        {
            "parameterKey": "Environment",
            "parameterValue": "prod",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "GitHubAppId",
            "parameterValue": "/restyled/prod/github-app-id",
            "resolvedValue": "5851",
            "usePreviousValue": null
        },
        {
            "parameterKey": "InstanceType",
            "parameterValue": "t2.small",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "InstanceKeyPair",
            "parameterValue": "patrick@pele",
            "resolvedValue": null,
            "usePreviousValue": null
        },
        {
            "parameterKey": "RestylerQueueName",
            "parameterValue": "restyled:agent:webhooks",
            "resolvedValue": null,
            "usePreviousValue": null
        }
    ],
    "parentChangeSetId": null,
    "rollbackConfiguration": null,
    "rootChangeSetId": null,
    "stackId": "arn:aws:cloudformation:us-east-1:760048635536:stack/prod-services-restyle-machines/38510350-b742-11eb-814c-0a2fadfa68a5",
    "stackName": "prod-services-restyle-machines",
    "status": "CREATE_COMPLETE",
    "statusReason": null,
    "tags": [
        {
            "key": "App",
            "value": "restyle-machines"
        },
        {
            "key": "CloudGenesis:stack-file",
            "value": "stacks/restyled.760048635536/us-east-1/prod/services/restyle-machines.yaml"
        },
        {
            "key": "Environment",
            "value": "prod"
        }
    ]
}

@pbrisbin pbrisbin merged commit ede4286 into main May 23, 2024
6 checks passed
@pbrisbin pbrisbin deleted the pb/update-restyled-machines branch May 23, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant